Restrict Search Replicas to Allocate only to Search dedicated node #17457
Conversation
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
|
❌ Gradle check result for f9c54c5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
|
❕ Gradle check result for 2d5b977: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17457 +/- ##
============================================
- Coverage 72.49% 72.49% -0.01%
- Complexity 65717 65727 +10
============================================
Files 5303 5304 +1
Lines 304793 304824 +31
Branches 44202 44208 +6
============================================
+ Hits 220966 220984 +18
- Misses 65693 65726 +33
+ Partials 18134 18114 -20 ☔ View full report in Codecov by Sentry. |
vinaykpud
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159 and
sachinpkale
as code owners
vinaykpud
requested review from
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
@vinaykpud can we combine this with a solution for #17421 so that we are not blocking replica allocation after this lands?, fix there should be a simple check. |
| List<String> replicas = internalCluster().startDataOnlyNodes(2); | ||
|
|
||
| // search node setting | ||
| client().admin() |
There was a problem hiding this comment.
we want to set this dynamically
github-actions
bot
added
the
enhancement
…ocking Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
|
❌ Gradle check result for 96f5eb3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
|
❌ Gradle check result for de1e719: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
In this PR we restrict Search replica to assign to any node if search replica dedicated node ie
cluster.routing.allocation.search.replica.dedicated.includesetting is not set. So by default search replicas will be unassigned state until we set dedicated search node by calling API like this or with yaml fileRelated Issues
Resolves #17422
Resolves #17421
Resolves #17334
Related to #15306
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.